[luci] Propagate qparam backward in onnx-fake quant model #14489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinevening
force-pushed
the
luci/prop_qparam_backward_onnx
branch
from
52da2a0 to
9aeb9b7
Compare
This propagates qparam backward in onnx-fake quant model. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
jinevening
force-pushed
the
luci/prop_qparam_backward_onnx
branch
from
9aeb9b7 to
afdbc7c
Compare
jinevening
commented
Dec 20, 2024
Comment on lines
-191
to
-192
| // Non-const input must have been quantized | ||
| assert(node->quantparam() != nullptr); |
There was a problem hiding this comment.
This pass is now used for QuantizeOnnxFakeQuantModelPass, which makes this assumption invalid.
Q) Is it safe to remove the assert?
A) I think yes. The assert was just for checking the behavior of QuantizeWithMinMaxPass. Even though node->quantparam() == nullptr, overwrite_quantparam can work without any problem.
|
To reviewers: This PR is for Llama3.2 quantization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propagates qparam backward in onnx-fake quant model.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]